Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent users from seeing rewinded cards #11654

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: prevent users from seeing rewinded cards #11654

merged 1 commit into from
Mar 12, 2025

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Mar 12, 2025 •
edited by jira bot
Loading

This PR resolves DIA-1171

Description

This PR fixes an issue happening to users when they are dismissing the infinite discovery

FYI: I will merge this so it makes it to the QA later. Happy to address feedback later

Screen.Recording.2025-03-12.at.08.34.20.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • prevent users from seeing rewinded cards on infinite discovery - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Mar 12, 2025
@MounirDhahri MounirDhahri marked this pull request as ready for review March 12, 2025 07:37
@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Mar 12, 2025
@MounirDhahri MounirDhahri enabled auto-merge (squash) March 12, 2025 09:49
@MounirDhahri MounirDhahri disabled auto-merge March 12, 2025 09:50
@MounirDhahri MounirDhahri merged commit 3774e5c into main Mar 12, 2025
4 of 8 checks passed
@MounirDhahri MounirDhahri deleted the fix/prevent-users-from-seeing-rewinded-cards branch March 12, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskounen iskounen iskounen approved these changes

@araujobarret araujobarret Awaiting requested review from araujobarret

Assignees

@MounirDhahri MounirDhahri

Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MounirDhahri @iskounen